[Whonix-devel] #11773 [Tor Launcher]: setup wizard UI flow improvements

[Tor Bug Tracker & Wiki]

#11773: setup wizard UI flow improvements
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  brade
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_revision
Component:  Tor Launcher                         |      Milestone:
 Severity:  Normal                               |        Version:
 Keywords:  tbb-usability,                       |     Resolution:
  TorBrowserTeam201601R                          |  Actual Points:
Parent ID:                                       |         Points:
  Sponsor:                                       |
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Let's suppose I choose the configure option using the default obfs3 PT and
 Tor Browser is giving me an error back (as seen in #18066). I click on the
 "Reconfigure" button but realize I might want to try to connect directly.
 Maybe it works. I click on the "Back" button on the Tor Bridges
 Configuration panel and am back at the first dialog (not counting the
 language selection one I had in my test build).

 I click on "Connect" and am confused now as I see two "Back" buttons which
 as it turns out behave differently as well. The one next to the Remove-
 Settings-and-Connect-button gets me back to the previous pane where I'd
 been coming from. But the other one brings me to the Tor Bridges
 Configuration pane with the bridge selection. Huh? :) And I only have a
 "Back" and a "Quit" button there. If I click "Back" and "Next", voila a
 "Next" button shows up again...

 I guess the Back button "built into" the dialog (i.e. the second one)
 should be hidden as well?

 And one coding style thing I thought we should improve
 {{{
   if (gIsBootstrapComplete)
     close();
   else if (wizardElem)
   {
     // If the user went down the "Configure" path and another error (e.g.,
     // Tor Exited) has not already been shown, display a generic message
     // with a "Reconfigure" button.
     let pageid = wizardElem.currentPage.pageid;
     if ((pageid != kWizardFirstPageID) && (pageid != "errorPanel"))
     {
       let msg =
 TorLauncherUtil.getLocalizedString("tor_bootstrap_failed");
       showErrorMessage(false, msg, true);
     }
   }
 }}}
 Could you put the if-clause in curly braces as well? Mixing both styles is
 error-prone.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11773#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online